Addressed issue titled "HDI naming" by changing the lower and upper hdi bound names in stats.py summary() function to hdi_{hdi_prob}_lb and hdi_{hdi_prob}_ub #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @YunwooC! I understand your contribution follows the discussion in #2306. I just want to mention that in ArviZ-stats, I used a different solution. We can use either one, just mentioning it so we unify them. |
OriolAbril
requested changes
May 23, 2025
There was a problem hiding this comment.
Agreed with @aloctavodia that it would be best to match arviz-stats. Also, note that the PR adds the _l/ub part between the probability and the % sign:
so it can't be merged as is even if matching arviz-stats weren't an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresed issue titled "HDI naming", ID: #2306. Improved naming for lower and higher hdi bounds in stats.py summary() function by renaming them to hdi_{hdi_prob}_ lb and hdi_{hdi_prob}_ ub.
Checklist
📚 Documentation preview 📚: https://arviz--2454.org.readthedocs.build/en/2454/