Skip to content

Addressed issue titled "HDI naming" by changing the lower and upper hdi bound names in stats.py summary() function to hdi_{hdi_prob}_lb and hdi_{hdi_prob}_ub #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

YunwooC
Copy link

@YunwooC YunwooC commented Apr 26, 2025

Description

Addresed issue titled "HDI naming", ID: #2306. Improved naming for lower and higher hdi bounds in stats.py summary() function by renaming them to hdi_{hdi_prob}_ lb and hdi_{hdi_prob}_ ub.

Checklist

  • Follows official PR format
  • Code style correct (follows pylint and black guidelines)

📚 Documentation preview 📚: https://arviz--2454.org.readthedocs.build/en/2454/

@aloctavodia
Copy link
Contributor

Thanks @YunwooC!

I understand your contribution follows the discussion in #2306. I just want to mention that in ArviZ-stats, I used a different solution. We can use either one, just mentioning it so we unify them.

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @aloctavodia that it would be best to match arviz-stats. Also, note that the PR adds the _l/ub part between the probability and the % sign:

imatge

so it can't be merged as is even if matching arviz-stats weren't an issue

@YunwooC YunwooC closed this May 23, 2025
@YunwooC YunwooC deleted the hdi-renaming branch May 23, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants